[Spark] Session-level time travel Spark 4.1 - Follow up to #15193#16205
Closed
gabeiglio wants to merge 3 commits into
Closed
[Spark] Session-level time travel Spark 4.1 - Follow up to #15193#16205gabeiglio wants to merge 3 commits into
gabeiglio wants to merge 3 commits into
Conversation
3 tasks
Contributor
Author
|
Closing as per feedback from iceberg sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #15193 for Session-Level time travel in Spark.
The previous PR works for Spark 4.0 and below since Iceberg still performs snapshot selection at scan time. But, in the new DSV2 that is not possible anymore, therefore, I am proposing a Spark extension that post-planning replaces DSV2 with the correct timestamp if there is one set in the spark conf, this allows us to still have this very useful time-travel conf.
This rule, follows the same pattern as ResolveBranch which is another poshoc rule created due to the same changes in DSV2